[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Move DRAM clear override to devicetree

Marshall Dawson (Code Review) gerrit at coreboot.org
Tue Oct 3 00:32:31 CEST 2017


Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/21858


Change subject: google/kahlee: Move DRAM clear override to devicetree
......................................................................

google/kahlee: Move DRAM clear override to devicetree

Kahlee needs to keep its DRAM contents after a reset.  Move this
override out of the OemCustomize.c file to a devicetree register
setting.

Change-Id: I3196cb8b94bec64e8ce59e4285cf8d97f442bd3d
Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
---
M src/mainboard/google/kahlee/OemCustomize.c
M src/mainboard/google/kahlee/devicetree.cb
2 files changed, 1 insertion(+), 6 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/21858/1

diff --git a/src/mainboard/google/kahlee/OemCustomize.c b/src/mainboard/google/kahlee/OemCustomize.c
index 50d504d..fcfde4a 100644
--- a/src/mainboard/google/kahlee/OemCustomize.c
+++ b/src/mainboard/google/kahlee/OemCustomize.c
@@ -36,9 +36,3 @@
 				0xff, 0xff, 0xff, 0xff, 0x00, 0x00, 0x00, 0x00),
 	PSO_END
 };
-
-void OemPostParams(AMD_POST_PARAMS *PostParams)
-{
-	/* disable memory clear for pstore memory storage and boot time */
-	PostParams->MemConfig.EnableMemClr = FALSE;
-}
diff --git a/src/mainboard/google/kahlee/devicetree.cb b/src/mainboard/google/kahlee/devicetree.cb
index 0ed3336..9bb0b43 100644
--- a/src/mainboard/google/kahlee/devicetree.cb
+++ b/src/mainboard/google/kahlee/devicetree.cb
@@ -18,6 +18,7 @@
 	{
 		{ {0xA0, 0x00} }, // socket 0 - Channel 0, slot 0
 	}"
+	register "dram_clear" = "DRAM_CONTENTS_KEEP"
 
 	device cpu_cluster 0 on
 		device lapic 10 on end

-- 
To view, visit https://review.coreboot.org/21858
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3196cb8b94bec64e8ce59e4285cf8d97f442bd3d
Gerrit-Change-Number: 21858
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171002/981a90ea/attachment-0001.html>


More information about the coreboot-gerrit mailing list