[coreboot-gerrit] Change in coreboot[master]: vc/amd/pi/00670F00: Remove HeapXXBuffer functions

[Martin Roth (Code Review)]

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/21848


Change subject: vc/amd/pi/00670F00: Remove HeapXXBuffer functions
......................................................................

vc/amd/pi/00670F00: Remove HeapXXBuffer functions

The HeapAllocateBuffer and HEAPDeallocateBuffer functions are not used
in Stoney Ridge, so get rid of them.

Change-Id: I716d5c8957ced52c25fd501697111b1b0b263467
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
1 file changed, 0 insertions(+), 60 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/21848/1

diff --git a/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
index 046dcb4..a4eef5a 100644
--- a/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
+++ b/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
@@ -51,19 +51,6 @@
 #include <console/console.h>
 #include <commonlib/loglevel.h>
 
-// TODO These need to be replaced with calls to CreateStruct()
-AGESA_STATUS
-HeapAllocateBuffer (
-  IN OUT   VOID *AllocateHeapParams,
-  IN OUT   VOID *StdHeader
-  );
-
-AGESA_STATUS
-HeapDeallocateBuffer (
-  IN       UINT32 BufferHandle,
-  IN       VOID *StdHeader
-  );
-
 CONST UINT32 ImageSignature = IMAGE_SIGNATURE;
 CONST UINT32 ModuleSignature = MODULE_SIGNATURE;
 CONST CHAR8 ModuleIdentifier[] = AGESA_ID;
@@ -412,51 +399,4 @@
 	if (!module) return;
 	Dispatcher = module->ModuleDispatcher;
 	Dispatcher(FchDataPtr);
-}
-
-// TODO This has to be removed
-AGESA_STATUS
-HeapAllocateBuffer (
-  IN OUT   VOID *AllocateHeapParams,
-  IN OUT   VOID *StdHeader
-  )
-{
-	MODULE_ENTRY Dispatcher = NULL;
-	const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
-
-	AMD_INTERFACE_PARAMS InterfaceParams = {};
-
-	if (!module) return AGESA_UNSUPPORTED;
-	Dispatcher = module->ModuleDispatcher;
-
-	InterfaceParams.StdHeader = *(AMD_CONFIG_PARAMS*)StdHeader;
-	InterfaceParams.StdHeader.Func = AMD_HEAP_ALLOCATE_BUFFER;
-
-	InterfaceParams.AllocationMethod = PreMemHeap;
-	InterfaceParams.NewStructPtr = AllocateHeapParams;
-
-	return Dispatcher(&InterfaceParams);
-}
-
-// TODO This has to be removed
-AGESA_STATUS
-HeapDeallocateBuffer (
-  IN       UINT32 BufferHandle,
-  IN       VOID *StdHeader
-  )
-{
-	MODULE_ENTRY Dispatcher = NULL;
-	const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
-
-	AMD_INTERFACE_PARAMS InterfaceParams = {};
-
-	if (!module) return AGESA_UNSUPPORTED;
-	Dispatcher = module->ModuleDispatcher;
-
-	InterfaceParams.StdHeader = *(AMD_CONFIG_PARAMS*)StdHeader;
-	InterfaceParams.StdHeader.Func = AMD_HEAP_DEALLOCATE_BUFFER;
-
-	InterfaceParams.NewStructPtr = &BufferHandle;
-
-	return Dispatcher(&InterfaceParams);
 }

-- 
To view, visit https://review.coreboot.org/21848
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I716d5c8957ced52c25fd501697111b1b0b263467
Gerrit-Change-Number: 21848
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171002/c2ef7371/attachment.html>