[coreboot-gerrit] Change in coreboot[master]: mainboard/google/kahlee: Update Kconfig string used in makefiles

Martin Roth (Code Review) gerrit at coreboot.org
Thu Nov 30 20:49:58 CET 2017


Martin Roth has uploaded this change for review. ( https://review.coreboot.org/22656


Change subject: mainboard/google/kahlee: Update Kconfig string used in makefiles
......................................................................

mainboard/google/kahlee: Update Kconfig string used in makefiles

Update the variable ${CONFIG_VARIANT_DIR} to use parens instead.  Either
is valid, but since we use parenthesis everywhere else, it's better to
be consistent.

BUG=b:69691210
TEST=Build grunt & kahlee

Change-Id: Ieffabaae5516a893f1dc1f7195a17c4cdeae8853
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/google/kahlee/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/22656/1

diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig
index 690faa9..80cfe88 100644
--- a/src/mainboard/google/kahlee/Kconfig
+++ b/src/mainboard/google/kahlee/Kconfig
@@ -58,7 +58,7 @@
 
 config FMDFILE
 	string
-	default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/variants/${CONFIG_VARIANT_DIR}/chromeos.fmd" if CHROMEOS
+	default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/variants/$(CONFIG_VARIANT_DIR)/chromeos.fmd" if CHROMEOS
 	default ""
 	help
 	  The build system creates a default FMAP from ROM_SIZE and CBFS_SIZE,

-- 
To view, visit https://review.coreboot.org/22656
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieffabaae5516a893f1dc1f7195a17c4cdeae8853
Gerrit-Change-Number: 22656
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171130/e46e4daf/attachment.html>


More information about the coreboot-gerrit mailing list