[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge/dimm_spd.c: Fix dereference before NULL check

Richard Spiegel (Code Review) gerrit at coreboot.org
Tue Nov 28 01:38:40 CET 2017


Hello build bot (Jenkins), Martin Roth, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/22612

to look at the new patch set (#2).

Change subject: amd/stoneyridge/dimm_spd.c: Fix dereference before NULL check
......................................................................

amd/stoneyridge/dimm_spd.c: Fix dereference before NULL check

Coverity reported pointer dev being dereferenced when assigning pointer
conf, before checking dev for NULL. Pointer dev must be NULL checked
before assigning a value to pointer conf.

Fixes coverity CID 1241851: Dereference before NULL check.

BUG=b:69810057
TEST=Build and platform boot to OS

Change-Id: Ic435b1290c9d3667b890ecc29c5147a25c16b96f
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/soc/amd/stoneyridge/dimm_spd.c
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/22612/2
-- 
To view, visit https://review.coreboot.org/22612
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic435b1290c9d3667b890ecc29c5147a25c16b96f
Gerrit-Change-Number: 22612
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171128/d0209696/attachment.html>


More information about the coreboot-gerrit mailing list