[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge/dimm_spd.c: Fix dereference before NULL check

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/22612 )

Change subject: amd/stoneyridge/dimm_spd.c: Fix dereference before NULL check
......................................................................


Patch Set 1: Code-Review+1

(3 comments)

+2 after the commit message is updated.

https://review.coreboot.org/#/c/22612/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/22612/1//COMMIT_MSG@12
PS1, Line 12: 
Please add a line like:
 Fixes coverity CID 1241851: Dereference before null check


https://review.coreboot.org/#/c/22612/1//COMMIT_MSG@13
PS1, Line 13: 69669995
Instead of marking this against the overall tracking bug, I'd ask that you create a new bug and mark that as blocking 69669995.


https://review.coreboot.org/#/c/22612/1//COMMIT_MSG@14
PS1, Line 14: 
Please add a "TEST=" line just saying what you did or what someone else would need to do to test the change.  TEST=Build or TEST=None are both valid, but if you did something more extensive, please describe it.

This should be done for all changes done for Google bugs.



-- 
To view, visit https://review.coreboot.org/22612
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic435b1290c9d3667b890ecc29c5147a25c16b96f
Gerrit-Change-Number: 22612
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 27 Nov 2017 23:34:29 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171127/d1dda617/attachment.html>