[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Add Intel SRAM common code support

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/22607 )

Change subject: soc/intel/common: Add Intel SRAM common code support
......................................................................


Patch Set 1:

(4 comments)

https://review.coreboot.org/#/c/22607/1/src/soc/intel/common/block/sram/sram.c
File src/soc/intel/common/block/sram/sram.c:

https://review.coreboot.org/#/c/22607/1/src/soc/intel/common/block/sram/sram.c@58
PS1, Line 58: read_resources
sram_read_resources


https://review.coreboot.org/#/c/22607/1/src/soc/intel/common/block/sram/sram.c@59
PS1, Line 59: set_resources
this can be replaced with pci_dev_set_resources as this one looks generic


https://review.coreboot.org/#/c/22607/1/src/soc/intel/common/block/sram/sram.c@60
PS1, Line 60: 	.enable_resources	= pci_dev_enable_resources,
why no .init function here? its always better to have weak link for .init


https://review.coreboot.org/#/c/22607/1/src/soc/intel/common/block/sram/sram.c@69
PS1, Line 69: pmc
sram



-- 
To view, visit https://review.coreboot.org/22607
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7870a3ca09ac7b57eb551d5eb42d8361d22f362a
Gerrit-Change-Number: 22607
Gerrit-PatchSet: 1
Gerrit-Owner: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 27 Nov 2017 07:45:50 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171127/e6704fcd/attachment.html>