[coreboot-gerrit] Change in coreboot[master]: intel/bd82x6x: Add missing IRQs in ACPI PIRQ link devices

Tobias Diedrich (Code Review) gerrit at coreboot.org
Sat Nov 25 22:21:14 CET 2017


Tobias Diedrich has uploaded this change for review. ( https://review.coreboot.org/22600


Change subject: intel/bd82x6x: Add missing IRQs in ACPI PIRQ link devices
......................................................................

intel/bd82x6x: Add missing IRQs in ACPI PIRQ link devices

pch_pirq_init() sets all PIRQ links to route to irq 11.
However in the ACPI data, on half the links irq 11 is missing.
The other half is missing irq 10.

This fixes a mostly cosmetic issue in the Linux messages:
  ACPI: PCI Interrupt Link [LNKA] (IRQs 3 4 5 6 7 10 12 14 15) *11
  ACPI: PCI Interrupt Link [LNKB] (IRQs 3 4 5 6 7 *11 12 14 15)
  ACPI: PCI Interrupt Link [LNKC] (IRQs 3 4 5 6 7 10 12 14 15) *11
  ACPI: PCI Interrupt Link [LNKD] (IRQs 3 4 5 6 7 *11 12 14 15)
  ACPI: PCI Interrupt Link [LNKE] (IRQs 3 4 5 6 7 10 12 14 15) *11
  ACPI: PCI Interrupt Link [LNKF] (IRQs 3 4 5 6 7 *11 12 14 15)
  ACPI: PCI Interrupt Link [LNKG] (IRQs 3 4 5 6 7 10 12 14 15) *11
  ACPI: PCI Interrupt Link [LNKH] (IRQs 3 4 5 6 7 *11 12 14 15)

Change-Id: I002147d702cacf54a233196932b30732f6a433b3
Signed-off-by: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
---
M src/southbridge/intel/bd82x6x/acpi/irqlinks.asl
1 file changed, 8 insertions(+), 8 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/22600/1

diff --git a/src/southbridge/intel/bd82x6x/acpi/irqlinks.asl b/src/southbridge/intel/bd82x6x/acpi/irqlinks.asl
index 2d02924..c78ec1b 100644
--- a/src/southbridge/intel/bd82x6x/acpi/irqlinks.asl
+++ b/src/southbridge/intel/bd82x6x/acpi/irqlinks.asl
@@ -29,7 +29,7 @@
 	Name (_PRS, ResourceTemplate()
 	{
 		IRQ(Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 7, 10, 12, 14, 15 }
+			{ 3, 4, 5, 6, 7, 10, 11, 12, 14, 15 }
 	})
 
 	// Current Resource Settings for this link
@@ -88,7 +88,7 @@
 	Name (_PRS, ResourceTemplate()
 	{
 		IRQ(Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 7, 11, 12, 14, 15 }
+			{ 3, 4, 5, 6, 7, 10, 11, 12, 14, 15 }
 	})
 
 	// Current Resource Settings for this link
@@ -147,7 +147,7 @@
 	Name (_PRS, ResourceTemplate()
 	{
 		IRQ(Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 7, 10, 12, 14, 15 }
+			{ 3, 4, 5, 6, 7, 10, 11, 12, 14, 15 }
 	})
 
 	// Current Resource Settings for this link
@@ -206,7 +206,7 @@
 	Name (_PRS, ResourceTemplate()
 	{
 		IRQ(Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 7, 11, 12, 14, 15 }
+			{ 3, 4, 5, 6, 7, 10, 11, 12, 14, 15 }
 	})
 
 	// Current Resource Settings for this link
@@ -265,7 +265,7 @@
 	Name (_PRS, ResourceTemplate()
 	{
 		IRQ(Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 7, 10, 12, 14, 15 }
+			{ 3, 4, 5, 6, 7, 10, 11, 12, 14, 15 }
 	})
 
 	// Current Resource Settings for this link
@@ -324,7 +324,7 @@
 	Name (_PRS, ResourceTemplate()
 	{
 		IRQ(Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 7, 11, 12, 14, 15 }
+			{ 3, 4, 5, 6, 7, 10, 11, 12, 14, 15 }
 	})
 
 	// Current Resource Settings for this link
@@ -383,7 +383,7 @@
 	Name (_PRS, ResourceTemplate()
 	{
 		IRQ(Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 7, 10, 12, 14, 15 }
+			{ 3, 4, 5, 6, 7, 10, 11, 12, 14, 15 }
 	})
 
 	// Current Resource Settings for this link
@@ -442,7 +442,7 @@
 	Name (_PRS, ResourceTemplate()
 	{
 		IRQ(Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 7, 11, 12, 14, 15 }
+			{ 3, 4, 5, 6, 7, 10, 11, 12, 14, 15 }
 	})
 
 	// Current Resource Settings for this link

-- 
To view, visit https://review.coreboot.org/22600
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I002147d702cacf54a233196932b30732f6a433b3
Gerrit-Change-Number: 22600
Gerrit-PatchSet: 1
Gerrit-Owner: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171125/62d36404/attachment.html>


More information about the coreboot-gerrit mailing list