[coreboot-gerrit] Change in coreboot[master]: inteltool: add hint for the compiler to avoid fall through warning
Felix Held (Code Review)
gerrit at coreboot.org
Sat Nov 25 01:50:27 CET 2017
Felix Held has uploaded this change for review. ( https://review.coreboot.org/22597
Change subject: inteltool: add hint for the compiler to avoid fall through warning
......................................................................
inteltool: add hint for the compiler to avoid fall through warning
The fall through is intended here, so add a comment that gcc will notice
and stop warning about this.
Change-Id: Id0cafb73a54ed4166830f6a4449558ab813a9dbe
Signed-off-by: Felix Held <felix-coreboot at felixheld.de>
---
M util/inteltool/pcie.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/22597/1
diff --git a/util/inteltool/pcie.c b/util/inteltool/pcie.c
index 541d9ca..af65a57 100644
--- a/util/inteltool/pcie.c
+++ b/util/inteltool/pcie.c
@@ -363,6 +363,7 @@
case PCI_DEVICE_ID_INTEL_CORE_2ND_GEN_E3:
dmi_registers = sandybridge_dmi_registers;
size = ARRAY_SIZE(sandybridge_dmi_registers);
+ // fall through
case PCI_DEVICE_ID_INTEL_CORE_3RD_GEN_D: /* pretty printing not implemented yet */
case PCI_DEVICE_ID_INTEL_CORE_3RD_GEN_M:
case PCI_DEVICE_ID_INTEL_CORE_3RD_GEN_E3:
--
To view, visit https://review.coreboot.org/22597
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id0cafb73a54ed4166830f6a4449558ab813a9dbe
Gerrit-Change-Number: 22597
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot at felixheld.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171125/4e723698/attachment.html>
More information about the coreboot-gerrit
mailing list