[coreboot-gerrit] Change in coreboot[master]: intel/gma: fix RPNFREQ_VAL bitmask

Felix Held (Code Review) gerrit at coreboot.org
Sat Nov 25 00:45:43 CET 2017


Felix Held has uploaded this change for review. ( https://review.coreboot.org/22596


Change subject: intel/gma: fix RPNFREQ_VAL bitmask
......................................................................

intel/gma: fix RPNFREQ_VAL bitmask

gma.c of Nehalem was copied from Sandy/Ivy Bridge, so fix it there too

Change-Id: I5f51c4929df83f948fcb7dc06e07ac3cc4ccf4f2
Signed-off-by: Felix Held <felix-coreboot at felixheld.de>
---
M src/northbridge/intel/nehalem/gma.c
M src/northbridge/intel/sandybridge/gma.c
2 files changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/22596/1

diff --git a/src/northbridge/intel/nehalem/gma.c b/src/northbridge/intel/nehalem/gma.c
index 0db8f3c..520b10e 100644
--- a/src/northbridge/intel/nehalem/gma.c
+++ b/src/northbridge/intel/nehalem/gma.c
@@ -491,7 +491,7 @@
 	/* RPNFREQ_VAL comes from MCHBAR 0x5998 23:16 (8 bits!? use 7) */
 	reg32 = MCHBAR32(0x5998);
 	reg32 >>= 16;
-	reg32 &= 0xef;
+	reg32 &= 0x7f;
 	reg32 <<= 25;
 	gtt_write(0xa008, reg32);
 
diff --git a/src/northbridge/intel/sandybridge/gma.c b/src/northbridge/intel/sandybridge/gma.c
index 61b9008..d9a9869 100644
--- a/src/northbridge/intel/sandybridge/gma.c
+++ b/src/northbridge/intel/sandybridge/gma.c
@@ -501,7 +501,7 @@
 	/* RPNFREQ_VAL comes from MCHBAR 0x5998 23:16 (8 bits!? use 7) */
 	reg32 = MCHBAR32(0x5998);
 	reg32 >>= 16;
-	reg32 &= 0xef;
+	reg32 &= 0x7f;
 	reg32 <<= 25;
 	gtt_write(0xa008, reg32);
 

-- 
To view, visit https://review.coreboot.org/22596
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f51c4929df83f948fcb7dc06e07ac3cc4ccf4f2
Gerrit-Change-Number: 22596
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot at felixheld.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171124/de36c935/attachment.html>


More information about the coreboot-gerrit mailing list