[coreboot-gerrit] Change in coreboot[master]: soraka: move WLAN_PE_RST gpio pad entry to early_gpio_table

Divya Chellappa (Code Review) gerrit at coreboot.org
Fri Nov 24 07:32:46 CET 2017


Hello Rizwan Qureshi, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/22587

to look at the new patch set (#4).

Change subject: soraka: move WLAN_PE_RST gpio pad entry to early_gpio_table
......................................................................

soraka: move WLAN_PE_RST gpio pad entry to early_gpio_table

On shutdown, Soraka enters Deep S5 and not S5 state. Setting
pad reset config of a gpio to RSMRST will not preserve
the gpio config across deepSx and the gpio should be configured again.
The WLAN_PE_RST signal should be brought up early in the bootflow
for giving the device enough time to initialized before PCIE init in FSP-S.
Hence, the gpio WLAN_PE_RST (GPP_B8) pad configuration is moved to
early pad configuration in bootblock.

BUG=none
BRANCH=none
TEST= WiFi functionality across S3, DeepS3, S0ix and warm/cold reboot.

Change-Id: I5c7a4a3871a3bff69c1136379c78a8368c6258a6
Signed-off-by: Divya Chellap <divya.chellappa at intel.com>
---
M src/mainboard/google/poppy/variants/soraka/gpio.c
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/22587/4
-- 
To view, visit https://review.coreboot.org/22587
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5c7a4a3871a3bff69c1136379c78a8368c6258a6
Gerrit-Change-Number: 22587
Gerrit-PatchSet: 4
Gerrit-Owner: Divya Chellappa <divya.chellappa at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171124/dd39c62f/attachment.html>


More information about the coreboot-gerrit mailing list