[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nautilus: Change IA/GT/SA slow slew rate set...

Chris Wang (Code Review) gerrit at coreboot.org
Fri Nov 24 06:48:55 CET 2017


Hello Chris Wang,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/22588

to review the following change.


Change subject: mb/google/poppy/variants/nautilus: Change IA/GT/SA slow slew rate settings
......................................................................

mb/google/poppy/variants/nautilus: Change IA/GT/SA slow slew rate settings

Change IA/GT/SA slow slew rate settings.
System's audible noise will be reduced with them.

- Slow slew rate for IA/GT/SA : fast/16
- Fast PKG C-state ramp for IA/GT/SA: disabled

BRANCH=master
BUG=b:66462881
TEST=compiled/verified

Change-Id: Ibf11aba7bafb3b02c510905d7d904507eee6394b
Signed-off-by: Chris Wang <chriswang at ami.corp-partner.google.com>
---
M src/mainboard/google/poppy/variants/nautilus/devicetree.cb
1 file changed, 8 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/22588/1

diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb
index efaea3f..6ee7a52 100644
--- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb
@@ -70,6 +70,14 @@
 	register "pirqg_routing" = "PCH_IRQ11"
 	register "pirqh_routing" = "PCH_IRQ11"
 
+	# VR Slew rate setting for improving audible noise
+	register "AcousticNoiseMitigation" = "1"
+	register "FastPkgCRampDisableIa" = "1"
+	register "FastPkgCRampDisableGt" = "1"
+	register "FastPkgCRampDisableSa" = "1"
+	register "SlowSlewRateForIa" = "3"      # Fast/16
+	register "SlowSlewRateForGt" = "3"      # Fast/16
+	register "SlowSlewRateForSa" = "3"      # Fast/16
 	# VR Settings Configuration for 4 Domains
 	#+----------------+-------+-------+-------+-------+
 	#| Domain/Setting |  SA   |  IA   | GTUS  |  GTS  |

-- 
To view, visit https://review.coreboot.org/22588
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf11aba7bafb3b02c510905d7d904507eee6394b
Gerrit-Change-Number: 22588
Gerrit-PatchSet: 1
Gerrit-Owner: Chris Wang <chriswang at ami.com.tw>
Gerrit-Reviewer: Chris Wang <chriswang at ami.corp-partner.google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171124/a7cf35c6/attachment.html>


More information about the coreboot-gerrit mailing list