[coreboot-gerrit] Change in coreboot[master]: mainboard/google/kahlee: Update Grunt for 16MB ROM chip

Martin Roth (Code Review) gerrit at coreboot.org
Thu Nov 23 05:16:32 CET 2017


Martin Roth has uploaded this change for review. ( https://review.coreboot.org/22580


Change subject: mainboard/google/kahlee: Update Grunt for 16MB ROM chip
......................................................................

mainboard/google/kahlee: Update Grunt for 16MB ROM chip

- Update Grunt to 16MB chip in Kconfig.
- Move chromeos.fmd into variant directory & update Kconfig with the new
location.
- Add Grunt specific chromeos.fmd file.

BUG=b:69691210
TEST=Build grunt; Build & Boot Kahlee

Change-Id: I8d2f5e3255984d0d9a18df560f84f6db03b73a78
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/google/kahlee/Kconfig
A src/mainboard/google/kahlee/variants/grunt/chromeos.fmd
R src/mainboard/google/kahlee/variants/kahlee/chromeos.fmd
3 files changed, 51 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/22580/1

diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig
index 7173f1d..6c9bfcc 100644
--- a/src/mainboard/google/kahlee/Kconfig
+++ b/src/mainboard/google/kahlee/Kconfig
@@ -16,7 +16,8 @@
 config BOARD_GOOGLE_BASEBOARD_KAHLEE
 	bool
 	select SOC_AMD_STONEYRIDGE_FT4
-	select BOARD_ROMSIZE_KB_8192
+	select BOARD_ROMSIZE_KB_16384 if BOARD_GOOGLE_GRUNT
+	select BOARD_ROMSIZE_KB_8192 if BOARD_GOOGLE_KAHLEE
 	select DRIVERS_PS2_KEYBOARD
 	select EC_GOOGLE_CHROMEEC
 	select EC_GOOGLE_CHROMEEC_LPC
@@ -53,6 +54,15 @@
 	string
 	default "Google_Kahlee"
 
+config FMDFILE
+	string
+	default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/variants/${CONFIG_VARIANT_DIR}/chromeos.fmd" if CHROMEOS
+	default ""
+	help
+	  The build system creates a default FMAP from ROM_SIZE and CBFS_SIZE,
+	  but in some cases more complex setups are required.
+	  When an fmd is specified, it overrides the default format.
+
 config MAX_CPUS
 	int
 	default 4
diff --git a/src/mainboard/google/kahlee/variants/grunt/chromeos.fmd b/src/mainboard/google/kahlee/variants/grunt/chromeos.fmd
new file mode 100644
index 0000000..674e6d7
--- /dev/null
+++ b/src/mainboard/google/kahlee/variants/grunt/chromeos.fmd
@@ -0,0 +1,40 @@
+FLASH at 0xFF000000 0x1000000 {
+	SI_BIOS at 0x0 0x1000000 {
+		RW_SECTION_A at 0x0 0x21E000 {
+			VBLOCK_A at 0x0 0x10000
+			FW_MAIN_A(CBFS)@0x10000 0x20DFC0
+			RW_FWID_A at 0x21DFC0 0x40
+		}
+		RW_SECTION_B at 0x21E000 0x21E000 {
+			VBLOCK_B at 0x0 0x10000
+			FW_MAIN_B(CBFS)@0x10000 0x20DFC0
+			RW_FWID_B at 0x21DFC0 0x40
+		}
+		UNIFIED_MRC_CACHE at 0x43C000 0x21000 {
+			RECOVERY_MRC_CACHE at 0x0 0x10000
+			RW_MRC_CACHE at 0x10000 0x10000
+			RW_VAR_MRC_CACHE at 0x20000 0x1000
+		}
+		RW_ELOG at 0x45D000 0x4000
+
+		RW_SHARED at 0x461000 0x4000 {
+			SHARED_DATA at 0x0 0x2000
+			VBLOCK_DEV at 0x2000 0x2000
+		}
+		RW_VPD at 0x465000 0x2000
+		RW_UNUSED at 0x467000 0x599000
+		RW_LEGACY at 0xA00000 0x200000
+
+		WP_RO at 0xC00000 0x400000 {
+			RO_VPD at 0x0 0x4000
+			RO_UNUSED at 0x4000 0x17B000
+			RO_SECTION at 0x17F000 0x281000 {
+				FMAP at 0x0 0x800
+				RO_FRID at 0x800 0x40
+				RO_FRID_PAD at 0x840 0x7c0
+				GBB at 0x1000 0x70000
+				COREBOOT(CBFS)@0x71000 0x210000
+			}
+		}
+	}
+}
diff --git a/src/mainboard/google/kahlee/chromeos.fmd b/src/mainboard/google/kahlee/variants/kahlee/chromeos.fmd
similarity index 100%
rename from src/mainboard/google/kahlee/chromeos.fmd
rename to src/mainboard/google/kahlee/variants/kahlee/chromeos.fmd

-- 
To view, visit https://review.coreboot.org/22580
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d2f5e3255984d0d9a18df560f84f6db03b73a78
Gerrit-Change-Number: 22580
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171123/cbac2fc1/attachment.html>


More information about the coreboot-gerrit mailing list