[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge/lpc.c: Use new wide IO functions

Marc Jones (Code Review) gerrit at coreboot.org
Thu Nov 23 01:42:57 CET 2017


Marc Jones has posted comments on this change. ( https://review.coreboot.org/22574 )

Change subject: amd/stoneyridge/lpc.c: Use new wide IO functions
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/22574/1/src/soc/amd/stoneyridge/lpc.c
File src/soc/amd/stoneyridge/lpc.c:

https://review.coreboot.org/#/c/22574/1/src/soc/amd/stoneyridge/lpc.c@256
PS1, Line 256: 			function_ret = sb_find_wideio_range(base, end);
this should be a better name. In this case wideio_size or something.


https://review.coreboot.org/#/c/22574/1/src/soc/amd/stoneyridge/lpc.c@269
PS1, Line 269: function_ret
and this should be wideio_range



-- 
To view, visit https://review.coreboot.org/22574
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8533e8ff766df8a8261298559aace7666487826d
Gerrit-Change-Number: 22574
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 23 Nov 2017 00:42:57 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171123/177090fa/attachment.html>


More information about the coreboot-gerrit mailing list