[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Delete early_setup.c

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/22569 )

Change subject: amd/stoneyridge: Delete early_setup.c
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/22569/1/src/mainboard/google/kahlee/ec.c
File src/mainboard/google/kahlee/ec.c:

https://review.coreboot.org/#/c/22569/1/src/mainboard/google/kahlee/ec.c@55
PS1, Line 55: printk(BIOS_DEBUG, "Failed to assign a range\n");
What's the impact of a failure here?  Should this maybe be a higher debug level than BIOS_DEBUG?

printk(BIOS_WARNING, "ERROR: Failed to assign a range\n");

die("ERROR: Failed to assign a range\n");



-- 
To view, visit https://review.coreboot.org/22569
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe75a2d5cc46641e9d0af462a8a0ba5bb7a0f9c3
Gerrit-Change-Number: 22569
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 23 Nov 2017 00:15:04 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171123/59fabd1b/attachment.html>