[coreboot-gerrit] Change in coreboot[master]: drivers/i2c/tpm/cr50: Simplify and increase init delay to 30 seconds

[Vadim Bendebury (Code Review)]

Vadim Bendebury has posted comments on this change. ( https://review.coreboot.org/22554 )

Change subject: drivers/i2c/tpm/cr50: Simplify and increase init delay to 30 seconds
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/22554/1/src/drivers/i2c/tpm/cr50.c
File src/drivers/i2c/tpm/cr50.c:

https://review.coreboot.org/#/c/22554/1/src/drivers/i2c/tpm/cr50.c@450
PS1, Line 450: 
             : 	if (ENV_VERSTAGE || ENV_BOOTBLOCK)
             : 		if (request_locality(chip))
             : 			return -1;
> As a sanity, do we want to check if locality is still claimed in other stag
actually, this is a good point, not as just a sanity issue: the old RO would release locality, so the new RW needs to claim it if there is RO/RW version mismatch.



-- 
To view, visit https://review.coreboot.org/22554
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba8445caf1342e3a5fefcb2664b0759a1a8e84e3
Gerrit-Change-Number: 22554
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 21 Nov 2017 18:26:09 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171121/8ac152bb/attachment.html>