[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Invoke pmc and hard reset only if CSE fails to ...

[Pratikkumar V Prajapati (Code Review)]

Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/22549 )

Change subject: soc/intel/cannonlake: Invoke pmc and hard reset only if CSE fails to reset
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/22549/1/src/soc/intel/cannonlake/reset.c
File src/soc/intel/cannonlake/reset.c:

https://review.coreboot.org/#/c/22549/1/src/soc/intel/cannonlake/reset.c@83
PS1, Line 83: if(!send_heci_reset_message())
            : 		return;
> We dont want to return from here if heci reset fails. we would try pmc and 
Aah.. i see what you mean, but even if heci reset works then also there is no point to return.



-- 
To view, visit https://review.coreboot.org/22549
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bb12554e5745d7704a1b684a3a51034bb35f787
Gerrit-Change-Number: 22549
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao <john.zhao at intel.corp-partner.google.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: John Zhao <john.zhao at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Pratikkumar Prajapati <pratikkumar.v.prajapati at intel.corp-partner.google.com>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 21 Nov 2017 04:33:25 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171121/29a6c8e8/attachment.html>