[coreboot-gerrit] Change in coreboot[master]: drivers/intel/gma: increase # of brightness steps

Patrick Rudolph (Code Review) gerrit at coreboot.org
Mon Nov 20 07:19:30 CET 2017


Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/22523 )

Change subject: drivers/intel/gma: increase # of brightness steps
......................................................................


Patch Set 1:

The original values are logarithmic, as you have to apply gamma correction for the human eye.
I'm with Nico here, the values should be per panel to account offset and exponential coefficient, but linear seems wrong.


-- 
To view, visit https://review.coreboot.org/22523
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b7a693a163adeceb3623c2703f3942328679ac4
Gerrit-Change-Number: 22523
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 20 Nov 2017 06:19:30 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171120/d88c599f/attachment.html>


More information about the coreboot-gerrit mailing list