[coreboot-gerrit] Change in coreboot[master]: drivers/intel/gma: increase # of brightness steps

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/22523 )

Change subject: drivers/intel/gma: increase # of brightness steps
......................................................................


Patch Set 1: Code-Review-1

I don't get it, doesn't this mean you have to hit the key 99 times to
get from lowest to highest brightness level?

I guess the old values are from a random dump. But they don't look bad
(for defaults). And having more than (let's say) 15 steps is pretty
weird, IMHO. OTOH, it makes sense to have the table per device. Some-
times one step is barely noticeable with one panel while it feels to
big with another.


-- 
To view, visit https://review.coreboot.org/22523
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b7a693a163adeceb3623c2703f3942328679ac4
Gerrit-Change-Number: 22523
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Sun, 19 Nov 2017 22:43:39 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171119/c267bb2c/attachment.html>