[coreboot-gerrit] Change in coreboot[master]: util/intelmetool: Fix lint errors and warnings

Patrick Rudolph (Code Review) gerrit at coreboot.org
Sun Nov 19 11:13:51 CET 2017


Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/22521

to look at the new patch set (#2).

Change subject: util/intelmetool: Fix lint errors and warnings
......................................................................

util/intelmetool: Fix lint errors and warnings

Clean the code to fix all errors and warnings.
No functional change.

Changes:
* Fix lines over 80chars
* Fix typos
* Restructure code to reduce ident level
* Move RCBA handling into own files
* Introduce helper functions for RCBA access
* Move GPL string into header
* Fix whitespace in macros

Change-Id: Ib8e3617ebb34c47959d6619dfbc7189045e6b8f7
Signed-off-by: Patrick Rudolph <siro at das-labor.org>
---
M util/intelmetool/Makefile
M util/intelmetool/intelmetool.c
M util/intelmetool/intelmetool.h
A util/intelmetool/rcba.c
A util/intelmetool/rcba.h
5 files changed, 330 insertions(+), 217 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/22521/2
-- 
To view, visit https://review.coreboot.org/22521
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib8e3617ebb34c47959d6619dfbc7189045e6b8f7
Gerrit-Change-Number: 22521
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171119/e9dd8a77/attachment.html>


More information about the coreboot-gerrit mailing list