[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Add generic IMC sleep and wakeup

Martin Roth (Code Review) gerrit at coreboot.org
Tue Nov 14 18:18:06 CET 2017


Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/22407 )

Change subject: amd/stoneyridge: Add generic IMC sleep and wakeup
......................................................................

amd/stoneyridge: Add generic IMC sleep and wakeup

Hudson code, the basis for soc//stoneyridge southbridge, has typically
contained direct calls to vendorcode/amd//ImcLib.c.  In an effort to
keep #include files clean in other stoneyridge files, put the new calls
into imc.c.

Change-Id: I830d5431635ac4acaf3c3c974cb452847dc147cd
Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
Reviewed-on: https://review.coreboot.org/22407
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Marc Jones <marc at marcjonesconsulting.com>
---
M src/soc/amd/stoneyridge/imc.c
M src/soc/amd/stoneyridge/include/soc/imc.h
2 files changed, 12 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Marc Jones: Looks good to me, approved



diff --git a/src/soc/amd/stoneyridge/imc.c b/src/soc/amd/stoneyridge/imc.c
index 6a5b5d8..a42a9e0 100644
--- a/src/soc/amd/stoneyridge/imc.c
+++ b/src/soc/amd/stoneyridge/imc.c
@@ -78,3 +78,13 @@
 	WriteECmsg(MSG_SYS_TO_IMC, AccessWidth8, &FunNum, &StdHeader);
 	WaitForEcLDN9MailboxCmdAck(&StdHeader);
 }
+
+void imc_sleep(void)
+{
+	ImcSleep(NULL);
+}
+
+void imc_wakeup(void)
+{
+	ImcWakeup(NULL);
+}
diff --git a/src/soc/amd/stoneyridge/include/soc/imc.h b/src/soc/amd/stoneyridge/include/soc/imc.h
index d613409..079df79 100644
--- a/src/soc/amd/stoneyridge/include/soc/imc.h
+++ b/src/soc/amd/stoneyridge/include/soc/imc.h
@@ -18,5 +18,7 @@
 
 void imc_reg_init(void);
 void enable_imc_thermal_zone(void);
+void imc_sleep(void);
+void imc_wakeup(void);
 
 #endif

-- 
To view, visit https://review.coreboot.org/22407
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I830d5431635ac4acaf3c3c974cb452847dc147cd
Gerrit-Change-Number: 22407
Gerrit-PatchSet: 4
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171114/14eef18b/attachment.html>


More information about the coreboot-gerrit mailing list