[coreboot-gerrit] Change in coreboot[master]: Remove duplicated #include amd_pci_defs.h

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/22461 )

Change subject: Remove duplicated #include amd_pci_defs.h
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

I wouldn't remove an include because it happens to be included in another file.  If anything, I would remove the header from amd_pci_util.h because nothing in that file requires it.

I would be OK squashing that into the previous patch too.

https://review.coreboot.org/#/c/22461/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/22461/1//COMMIT_MSG@7
PS1, Line 7: Remove duplicated #include amd_pci_defs.h
Add soc/amd/common:



-- 
To view, visit https://review.coreboot.org/22461
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I258d549d3eea3fb8919c0cddbb41dc2bc4738c4e
Gerrit-Change-Number: 22461
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 14 Nov 2017 03:47:11 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171114/4ba751e3/attachment.html>