[coreboot-gerrit] Change in coreboot[master]: src/soc/amd/stoneyridge/include/amd_pci_defs.h: move file to common/i...

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/22460 )

Change subject: src/soc/amd/stoneyridge/include/amd_pci_defs.h: move file to common/include.
......................................................................


Patch Set 1:

(4 comments)

I'm not sure I like the idea of moving this to soc/amd/common.  I've been leery about moving FCH items there without knowing what the next generation looks like.  I'd like to hear some other opinions.

https://review.coreboot.org/#/c/22460/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/22460/1//COMMIT_MSG@7
PS1, Line 7: src/soc/amd/stoneyridge/include/amd_pci_defs.h: move file to common/include.
Gerrit probably already complained about the commit message subject line being too long.  You definitely don't need the entire path/to/filename here.  amd/stoneyridge is adequate.


https://review.coreboot.org/#/c/22460/1//COMMIT_MSG@7
PS1, Line 7: .
Don't put a period at the end of your subject line.


https://review.coreboot.org/#/c/22460/1/src/soc/amd/common/amd_pci_util.c
File src/soc/amd/common/amd_pci_util.c:

https://review.coreboot.org/#/c/22460/1/src/soc/amd/common/amd_pci_util.c@22
PS1, Line 22: include/
I kind of don't like this.  I would prefer to see it the header under amdblocks or simply in common.  Then you don't need this extra path.


https://review.coreboot.org/#/c/22460/1/src/soc/amd/common/include/amd_pci_int_defs.h
File src/soc/amd/common/include/amd_pci_int_defs.h:

https://review.coreboot.org/#/c/22460/1/src/soc/amd/common/include/amd_pci_int_defs.h@45
PS1, Line 45: 14h.2
Not present in Stoney.  I don't know if the 0x13 even applies or if AMD forgot to take it out of the BKDG text.

There are other problems in this file, even for Stoney Ridge.



-- 
To view, visit https://review.coreboot.org/22460
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69e0a54e5d64ae28919871c687a0177786b789c8
Gerrit-Change-Number: 22460
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 14 Nov 2017 03:47:03 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171114/b7827b0b/attachment.html>