[coreboot-gerrit] Change in coreboot[master]: Mainboard carrizo_fch.asl: move code to soc

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/22455 )

Change subject: Mainboard carrizo_fch.asl: move code to soc
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/22455/1/src/soc/amd/stoneyridge/acpi/soc_fch.asl
File src/soc/amd/stoneyridge/acpi/soc_fch.asl:

https://review.coreboot.org/#/c/22455/1/src/soc/amd/stoneyridge/acpi/soc_fch.asl@4
PS1, Line 4: 6
> I thought I was required to update the copyright of any file I worked, incl
No problem.

The copyright is on the contents of the file.  Technically, you can copyright any change you make, but really it's only for "creative" changes.  Changing whitespace, for example, legally qualifies for a copyright change, but if I saw someone updating the copyright for whitespace fixes, I'd probably object.

In this case, since the contents of the file didn't change, the copyright shouldn't change.



-- 
To view, visit https://review.coreboot.org/22455
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5de2020411794bfcd3730789f62af9c9834a018b
Gerrit-Change-Number: 22455
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 13 Nov 2017 21:28:08 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171113/24f5a630/attachment.html>