[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nautilus: add nhlt support for SPK, DMIC
Naveen Manohar (Code Review)
gerrit at coreboot.org
Mon Nov 13 21:00:40 CET 2017
Naveen Manohar has uploaded this change for review. ( https://review.coreboot.org/22457
Change subject: mb/google/poppy/variants/nautilus: add nhlt support for SPK, DMIC
......................................................................
mb/google/poppy/variants/nautilus: add nhlt support for SPK, DMIC
Nautilus board uses max989357a speaker codec and 3CH DMIC.
Select the appropriate NHLT blob to be packaged in CBFS.
Also generate the required ACPI NHLT table for codec
and the supported topology in nautilus.
Removes unwanted DMIC blob pick for nautilus
BUG=b:68686020
TEST=With the required driver support in kernel verify that
the Audio plays on Speaker and captures on 3CH DMIC
Change-Id: Ie90af02e0935029f53f9020bd78027b6eb31a187
Signed-off-by: Naveen Manohar <naveen.m at intel.com>
---
M src/mainboard/google/poppy/Kconfig
M src/mainboard/google/poppy/variants/nautilus/nhlt.c
2 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/22457/1
diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig
index f725113..596c33f 100644
--- a/src/mainboard/google/poppy/Kconfig
+++ b/src/mainboard/google/poppy/Kconfig
@@ -56,7 +56,9 @@
config INCLUDE_NHLT_BLOBS_NAUTILUS
bool "Include blobs for nautilus audio."
+ select NHLT_DMIC_3CH
select NHLT_DA7219
+ select NHLT_MAX98927
config MAINBOARD_DIR
string
diff --git a/src/mainboard/google/poppy/variants/nautilus/nhlt.c b/src/mainboard/google/poppy/variants/nautilus/nhlt.c
index b6496e2..efb1b67 100644
--- a/src/mainboard/google/poppy/variants/nautilus/nhlt.c
+++ b/src/mainboard/google/poppy/variants/nautilus/nhlt.c
@@ -20,7 +20,16 @@
void variant_nhlt_init(struct nhlt *nhlt)
{
+ /* 3 Channel DMIC array. */
+ if (nhlt_soc_add_dmic_array(nhlt, 3))
+ printk(BIOS_ERR, "Couldn't add 3CH DMIC array.\n");
+
/* Dialog DA7219 Headset codec. */
if (nhlt_soc_add_da7219(nhlt, AUDIO_LINK_SSP1))
printk(BIOS_ERR, "Couldn't add Dialog DA7219.\n");
+
+ /* MAXIM Smart Amps for left and right speakers. */
+ if (nhlt_soc_add_max98357(nhlt, AUDIO_LINK_SSP0))
+ printk(BIOS_ERR, "Couldn't add Maxim_98357 codec.\n");
+
}
--
To view, visit https://review.coreboot.org/22457
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie90af02e0935029f53f9020bd78027b6eb31a187
Gerrit-Change-Number: 22457
Gerrit-PatchSet: 1
Gerrit-Owner: Naveen Manohar <naveen.m at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171113/eb616ec1/attachment.html>
More information about the coreboot-gerrit
mailing list