[coreboot-gerrit] Change in coreboot[master]: mb/google/eve: Use rt5663 driver and set properties

Duncan Laurie (Code Review) gerrit at coreboot.org
Mon Nov 13 16:29:09 CET 2017


Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/22446


Change subject: mb/google/eve: Use rt5663 driver and set properties
......................................................................

mb/google/eve: Use rt5663 driver and set properties

Use the rt5663 driver and provide values for the offsets.

BUG=b:62712227
TEST=build and boot on eve and ensure rt5663 is functional.

Change-Id: I88113616e4b7c79cff840168b7c54ae754dfa75f
Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
Original-Change-Id: Ica4090636c1ff29f0298114e62c9cc6fe167a425
Original-Signed-off-by: Duncan Laurie <dlaurie at google.com>
Original-Reviewed-on: https://chromium-review.googlesource.com/611606
Original-Reviewed-by: Furquan Shaikh <furquan at chromium.org>
Original-Reviewed-by: Hsinyu Chao <hychao at chromium.org>
---
M src/mainboard/google/eve/Kconfig
M src/mainboard/google/eve/devicetree.cb
2 files changed, 6 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/22446/1

diff --git a/src/mainboard/google/eve/Kconfig b/src/mainboard/google/eve/Kconfig
index f576fa7..54b8868 100644
--- a/src/mainboard/google/eve/Kconfig
+++ b/src/mainboard/google/eve/Kconfig
@@ -8,6 +8,7 @@
 	select DRIVERS_I2C_HID
 	select DRIVERS_PS2_KEYBOARD
 	select DRIVERS_I2C_MAX98927
+	select DRIVERS_I2C_RT5663
 	select DRIVERS_SPI_ACPI
 	select EC_GOOGLE_CHROMEEC
 	select EC_GOOGLE_CHROMEEC_BOARDID
diff --git a/src/mainboard/google/eve/devicetree.cb b/src/mainboard/google/eve/devicetree.cb
index f0c2b69..069c2b0 100644
--- a/src/mainboard/google/eve/devicetree.cb
+++ b/src/mainboard/google/eve/devicetree.cb
@@ -289,11 +289,12 @@
 				register "name" = ""MAXL""
 				device i2c 3a on end
 			end
-			chip drivers/i2c/generic
-				register "hid" = ""10EC5663""
-				register "name" = ""RT53""
-				register "desc" = ""Realtek RT5663""
+			chip drivers/i2c/rt5663
 				register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_D9)"
+				register "dc_offset_l_manual" = "0xffd160"
+				register "dc_offset_r_manual" = "0xffd1c0"
+				register "dc_offset_l_manual_mic" = "0xff8a10"
+				register "dc_offset_r_manual_mic" = "0xff8ab0"
 				device i2c 13 on end
 			end
 			chip drivers/i2c/generic

-- 
To view, visit https://review.coreboot.org/22446
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I88113616e4b7c79cff840168b7c54ae754dfa75f
Gerrit-Change-Number: 22446
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171113/20219d2c/attachment-0001.html>


More information about the coreboot-gerrit mailing list