[coreboot-gerrit] Change in coreboot[master]: vendorcode/amd/pi/00670f00: Set ModuleIdentifier to be 8 bytes

[Martin Roth (Code Review)]

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/22430


Change subject: vendorcode/amd/pi/00670f00: Set ModuleIdentifier to be 8 bytes
......................................................................

vendorcode/amd/pi/00670f00: Set ModuleIdentifier to be 8 bytes

ModuleIdentifier must be 8 bytes.   Every other location else that uses
this value explicityly defines it as 8 bytes.  If it's initialized here
to less than 8 bytes, it gets passed to those other locations with
garbage at the end and fails to load the AGESA binary.

TEST=Build & boot Kahlee
BUG=B:69165234

Change-Id: I11fc90748f49782e2b16ee5326aee17cfe92d0bc
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/22430/1

diff --git a/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
index 5a41897..ec414b4 100644
--- a/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
+++ b/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
@@ -53,7 +53,7 @@
 
 CONST UINT32 ImageSignature = IMAGE_SIGNATURE;
 CONST UINT32 ModuleSignature = MODULE_SIGNATURE;
-CONST CHAR8 ModuleIdentifier[] = AGESA_ID;
+CONST CHAR8 ModuleIdentifier[8] = AGESA_ID;
 
 /**********************************************************************
  * Interface call:  AmdCreateStruct

-- 
To view, visit https://review.coreboot.org/22430
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11fc90748f49782e2b16ee5326aee17cfe92d0bc
Gerrit-Change-Number: 22430
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171111/c2debb50/attachment.html>