[coreboot-gerrit] Change in coreboot[master]: google/chell: add missing SPD hex files

Matt DeVillier (Code Review) gerrit at coreboot.org
Thu Nov 9 22:56:07 CET 2017


Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/22402


Change subject: google/chell: add missing SPD hex files
......................................................................

google/chell: add missing SPD hex files

Several SPD hex files for chell were missing from upstream coreboot
(as compared to the Chromium tree/branch), which resulted in the
incorrect type and amount of RAM being reported on chell boards
with > 4GB RAM.  Add these missing files and their Makefile entries.

TEST: boot google/chell m7/16GB config and observe correct RAM
type and amount reported via dmidecode and cbmem console log.

Change-Id: I37d708c96e754b438e40fc413420aa64bf234c29
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/mainboard/google/chell/spd/Makefile.inc
A src/mainboard/google/chell/spd/hynix_dimm_H9CCNNN8GTALAR.spd.hex
A src/mainboard/google/chell/spd/hynix_dimm_H9CCNNNBJTALAR.spd.hex
A src/mainboard/google/chell/spd/hynix_dimm_H9CCNNNCLGALAR.spd.hex
M src/mainboard/google/chell/spd/samsung_dimm_K4E6E304EB-EGCF.spd.hex
A src/mainboard/google/chell/spd/samsung_dimm_K4E8E324EB-EGCF.spd.hex
A src/mainboard/google/chell/spd/samsung_dimm_K4EBE304EB-EGCF.spd.hex
7 files changed, 89 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/22402/1

diff --git a/src/mainboard/google/chell/spd/Makefile.inc b/src/mainboard/google/chell/spd/Makefile.inc
index f78f3f6..ed46a03 100644
--- a/src/mainboard/google/chell/spd/Makefile.inc
+++ b/src/mainboard/google/chell/spd/Makefile.inc
@@ -25,6 +25,11 @@
 SPD_SOURCES += hynix_dimm_H9CCNNNBJTMLAR        # 0b0011
 SPD_SOURCES += hynix_dimm_H9CCNNNCLTMLAR        # 0b0100
 SPD_SOURCES += samsung_dimm_K4E6E304EB-EGCF     # 0b0101
+SPD_SOURCES += samsung_dimm_K4EBE304EB-EGCF     # 0b0110
+SPD_SOURCES += samsung_dimm_K4E8E324EB-EGCF     # 0b0111
+SPD_SOURCES += hynix_dimm_H9CCNNNBJTALAR        # 0b1000
+SPD_SOURCES += hynix_dimm_H9CCNNNCLGALAR        # 0b1001
+SPD_SOURCES += hynix_dimm_H9CCNNN8GTALAR        # 0b1010
 
 SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f).spd.hex)
 
diff --git a/src/mainboard/google/chell/spd/hynix_dimm_H9CCNNN8GTALAR.spd.hex b/src/mainboard/google/chell/spd/hynix_dimm_H9CCNNN8GTALAR.spd.hex
new file mode 100644
index 0000000..5c1332e
--- /dev/null
+++ b/src/mainboard/google/chell/spd/hynix_dimm_H9CCNNN8GTALAR.spd.hex
@@ -0,0 +1,16 @@
+91 20 F1 03 05 19 05 03 03 11 01 08 09 00 40 05
+78 78 90 50 90 11 50 E0 90 06 3C 3C 01 90 00 00
+00 00 CA FA 00 00 00 A8 00 88 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 80 AD 01 00 00 00 00 00 00 00 00
+48 39 43 43 4E 4E 4E 38 47 54 41 4C 41 52 2D 4E
+55 44 00 00 80 AD 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
diff --git a/src/mainboard/google/chell/spd/hynix_dimm_H9CCNNNBJTALAR.spd.hex b/src/mainboard/google/chell/spd/hynix_dimm_H9CCNNNBJTALAR.spd.hex
new file mode 100644
index 0000000..7c7c8d2
--- /dev/null
+++ b/src/mainboard/google/chell/spd/hynix_dimm_H9CCNNNBJTALAR.spd.hex
@@ -0,0 +1,16 @@
+91 20 F1 03 05 19 05 0B 03 11 01 08 09 00 40 05
+78 78 90 50 90 11 50 E0 90 06 3C 3C 01 90 00 00
+00 00 CA FA 00 00 00 A8 00 88 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 80 AD 01 00 00 00 00 00 00 00 00
+48 39 43 43 4E 4E 4E 42 4A 54 41 4C 41 52 2D 4E
+55 44 00 00 80 AD 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
diff --git a/src/mainboard/google/chell/spd/hynix_dimm_H9CCNNNCLGALAR.spd.hex b/src/mainboard/google/chell/spd/hynix_dimm_H9CCNNNCLGALAR.spd.hex
new file mode 100644
index 0000000..24c032b
--- /dev/null
+++ b/src/mainboard/google/chell/spd/hynix_dimm_H9CCNNNCLGALAR.spd.hex
@@ -0,0 +1,16 @@
+91 20 F1 03 05 1A 05 0A 03 11 01 08 09 00 40 05
+78 78 90 50 90 11 50 E0 90 06 3C 3C 01 90 00 00
+00 00 CA FA 00 00 00 A8 00 88 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 80 AD 01 00 00 00 00 00 00 00 00
+48 39 43 43 4E 4E 4E 43 4C 47 41 4C 41 52 2D 4E
+55 44 00 00 80 AD 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
diff --git a/src/mainboard/google/chell/spd/samsung_dimm_K4E6E304EB-EGCF.spd.hex b/src/mainboard/google/chell/spd/samsung_dimm_K4E6E304EB-EGCF.spd.hex
index 776bbf4..f291630 100644
--- a/src/mainboard/google/chell/spd/samsung_dimm_K4E6E304EB-EGCF.spd.hex
+++ b/src/mainboard/google/chell/spd/samsung_dimm_K4E6E304EB-EGCF.spd.hex
@@ -1,7 +1,7 @@
-91 20 F1 03 04 12 05 0A 03 11 01 08 09 00 50 05
-78 78 90 50 90 11 50 E0 10 04 3C 3C 01 90 00 00
-00 80 ca fa 00 00 00 A8 00 00 00 00 00 00 00 00
-00 00 00 00 00 00 00 00 00 00 00 00 0F 11 02 00
+91 20 F1 03 05 19 05 0B 03 11 01 08 09 00 40 05
+78 78 90 50 90 11 50 E0 90 06 3C 3C 01 90 00 00
+00 00 CA FA 00 00 00 A8 00 88 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
diff --git a/src/mainboard/google/chell/spd/samsung_dimm_K4E8E324EB-EGCF.spd.hex b/src/mainboard/google/chell/spd/samsung_dimm_K4E8E324EB-EGCF.spd.hex
new file mode 100644
index 0000000..7d72967
--- /dev/null
+++ b/src/mainboard/google/chell/spd/samsung_dimm_K4E8E324EB-EGCF.spd.hex
@@ -0,0 +1,16 @@
+91 20 F1 03 05 19 05 03 03 11 01 08 09 00 40 05
+78 78 90 50 90 11 50 E0 90 06 3C 3C 01 90 00 00
+00 00 CA FA 00 00 00 A8 00 88 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 80 CE 01 00 00 55 00 00 00 00 00
+4B 34 45 38 45 33 32 34 45 42 2D 45 47 43 46 20
+20 20 00 00 80 CE 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
diff --git a/src/mainboard/google/chell/spd/samsung_dimm_K4EBE304EB-EGCF.spd.hex b/src/mainboard/google/chell/spd/samsung_dimm_K4EBE304EB-EGCF.spd.hex
new file mode 100644
index 0000000..930d27f
--- /dev/null
+++ b/src/mainboard/google/chell/spd/samsung_dimm_K4EBE304EB-EGCF.spd.hex
@@ -0,0 +1,16 @@
+91 20 F1 03 05 1A 05 0A 03 11 01 08 09 00 40 05
+78 78 90 50 90 11 50 E0 90 06 3C 3C 01 90 00 00
+00 00 CA FA 00 00 00 A8 00 88 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 0F 11 02 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 80 CE 01 00 00 55 00 00 00 00 00
+4B 34 45 42 45 33 30 34 45 42 2D 45 47 43 46 20
+20 20 00 00 80 CE 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

-- 
To view, visit https://review.coreboot.org/22402
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I37d708c96e754b438e40fc413420aa64bf234c29
Gerrit-Change-Number: 22402
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171109/dad0e9e8/attachment-0001.html>


More information about the coreboot-gerrit mailing list