[coreboot-gerrit] Change in coreboot[master]: intel/cannonlake_rvp: Clean up GPIO programming

Lijian Zhao (Code Review) gerrit at coreboot.org
Tue Nov 7 20:15:03 CET 2017


Lijian Zhao has uploaded a new patch set (#3). ( https://review.coreboot.org/22326 )

Change subject: intel/cannonlake_rvp: Clean up GPIO programming
......................................................................

intel/cannonlake_rvp: Clean up GPIO programming

Since we move from cannonlake U DDR 4 platform to cannonlake U LPDDR4
platform, it is also critical to revisit the GPIO settings as they are
different. Remove unused GPIO setting for old platform, and clean up the
native function definition. PAD_CFG_NF can only select NF1,NF2 ..., set
to GPIO mode is illegal.

TEST=Boot up in chromeos successfully.

Change-Id: I0022b791bd8459ea2afdcd0241b603ce81408785
Signed-off-by: Lijian Zhao <lijian.zhao at intel.com>
---
M src/mainboard/intel/cannonlake_rvp/variants/baseboard/gpio.c
1 file changed, 19 insertions(+), 49 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/22326/3
-- 
To view, visit https://review.coreboot.org/22326
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0022b791bd8459ea2afdcd0241b603ce81408785
Gerrit-Change-Number: 22326
Gerrit-PatchSet: 3
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: John Zhao <john.zhao at intel.com>
Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Wei-nan Liu <wei-nan.liu at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171107/e7add172/attachment.html>


More information about the coreboot-gerrit mailing list