[coreboot-gerrit] Change in coreboot[master]: util/inteltool Add Skylake DMIBAR register dumping

[Maximilian Schander (Code Review)]

Maximilian Schander has uploaded this change for review. ( https://review.coreboot.org/22345


Change subject: util/inteltool Add Skylake DMIBAR register dumping
......................................................................

util/inteltool Add Skylake DMIBAR register dumping

Register definitions were taken from
 * 6th Generation Intel Processor Families for S-Platform Col 2
 * Page 117
 * 332688-003EN

Tested on a 6th gen skylake mobile cpu and capability registers do match up
with the default values.

Change-Id: I636f6c3d045e297f1439d3e88e43f41e03db4c8e
Signed-off-by: Maximilian Schander <coreboot at mimoja.de>
---
M util/inteltool/pcie.c
1 file changed, 70 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/22345/1

diff --git a/util/inteltool/pcie.c b/util/inteltool/pcie.c
index 67b0e19..7e28cc3 100644
--- a/util/inteltool/pcie.c
+++ b/util/inteltool/pcie.c
@@ -171,6 +171,68 @@
 /*  ... - Reserved */
 };
 
+
+/*
+ * All Skylake DMI Registers per
+ *
+ * 6th Generation Intel Processor Families for S-Platform Col 2
+ * Page 117
+ * 332688-003EN
+ */
+static const io_register_t skylake_dmi_registers[] = {
+	{ 0x00, 4, "DMIVCECH"   }, // DMI Virtual Channel Enhanced Capability
+	{ 0x04, 4, "DMIPVCCAP1" }, // DMI Port VC Capability Register 1
+	{ 0x08, 4, "DMIPVCCAP2" }, // DMI Port VC Capability Register 2
+	{ 0x0C, 2, "DMIPVCCTL"  }, // DMI Port VC Control
+/*	{ 0x0E, 2, "RSVD"       }, // Reserved */
+	{ 0x10, 4, "DMIVC0RCAP" }, // DMI VC0 Resource Capability
+	{ 0x14, 4, "DMIVC0RCTL" }, // DMI VC0 Resource Control
+/*	{ 0x18, 2, "RSVD"       }, // Reserved */
+	{ 0x1A, 2, "DMIVC0RSTS" }, // DMI VC0 Resource Status
+	{ 0x1C, 4, "DMIVC1RCAP" }, // DMI VC1 Resource Capability
+	{ 0x20, 4, "DMIVC1RCTL" }, // DMI VC1 Resource Control
+/*	{ 0x24, 2, "RSVD"       }, // Reserved */
+	{ 0x26, 2, "DMIVC1RSTS" }, // DMI VC1 Resource Status
+/*	{ 0x28, 4  "RSVD"       }, // Reserved */
+/*	{ 0x2C, 4, "RSVD"       }, // Reserved */
+/*	{ 0x30, 2, "RSVD"       }, // Reserved */
+/*	{ 0x32, 4, "RSVD"       }, // Reserved */
+	{ 0x34, 4, "DMIVCMRCAP" }, // DMI VCm Resource Capability
+	{ 0x38, 4, "DMIVCMRCTL" }, // DMI VCm Resource Control
+/*	{ 0x3C, 2, "RSVD"       }, // Reserved */
+	{ 0x3E, 2, "DMIVCMRSTS" }, // DMI VCm Resource Status
+	{ 0x40, 4, "DMIRCLDECH" }, // DMI Root Complex Link Declaration */
+	{ 0x44, 4, "DMIESD"     }, // DMI Element Self Description
+/*	{ 0x48, 4, "RSVD"       }, // Reserved */
+/*	{ 0x4C, 4, "RSVD"       }, // Reserved */
+	{ 0x50, 4, "DMILE1D"    }, // DMI Link Entry 1 Description
+/*	{ 0x54, 4, "RSVD"       }, // Reserved */
+	{ 0x58, 4, "DMILE1A"    }, // DMI Link Entry 1 Address
+	{ 0x5C, 4, "DMILUE1A"   }, // DMI Link Upper Entry 1 Address
+	{ 0x60, 4, "DMILE2D"    }, // DMI Link Entry 2 Description
+/*	{ 0x64, 4, "RSVD"       }, // Reserved */
+	{ 0x68, 4, "DMILE2A"    }, // DMI Link Entry 2 Address
+/*	{ 0x6C, 4, "RSVD"       }, // Reserved */
+/*	{ 0x70, 4, "RSVD"       }, // Reserved */
+/*	{ 0x74, 4, "RSVD"       }, // Reserved */
+/*	{ 0x78, 4, "RSVD"       }, // Reserved */
+/*	{ 0x7C, 4, "RSVD"       }, // Reserved */
+/*	{ 0x80, 4, "RSVD"       }, // Reserved */
+	{ 0x84, 4, "LCAP"       }, // Link Capabilities
+	{ 0x88, 2, "LCTL"       }, // Link Control
+	{ 0x8A, 2, "LSTS"       }, // DMI Link Status
+	{ 0x98, 2, "LCTL2"      }, // Link Control 2
+	{ 0x9A, 2, "LSTS2"      }, // DMI Link Status 2
+/*  ... - Reserved */
+	{ 0x1C4, 4, "DMIUESTS"  }, // DMI Uncorrectable Error Status
+	{ 0x1C8, 4, "DMIUEMSK"  }, // DMI Uncorrectable Error Mask
+	{ 0x1CC, 4, "DMIUESEV"  }, // DMI Uncorrectable Error Mask
+	{ 0x1D0, 4, "DMICESTS"  }, // DMI Correctable Error Status
+	{ 0x1D4, 4, "DMICEMSK"  }, // DMI Correctable Error Mask
+/*  ... - Reserved */
+};
+
+
 /*
  * Egress Port Root Complex MMIO configuration space
  */
@@ -335,7 +397,14 @@
 		dmibar_phys |= ((uint64_t)pci_read_long(nb, 0x6c)) << 32;
 		dmibar_phys &= 0x0000007ffffff000UL; /* 38:12 */
 		break;
-
+	case PCI_DEVICE_ID_INTEL_CORE_6TH_GEN_M:
+	case PCI_DEVICE_ID_INTEL_CORE_6TH_GEN_WST:
+		dmi_registers = skylake_dmi_registers;
+		size = ARRAY_SIZE(skylake_dmi_registers);
+		dmibar_phys = pci_read_long(nb, 0x68);
+		dmibar_phys |= ((uint64_t)pci_read_long(nb, 0x6c)) << 32;
+		dmibar_phys &= 0x0000007ffffff000UL; /* 38:12 */
+		break;
 	default:
 		printf("Error: Dumping DMIBAR on this northbridge is not (yet) supported.\n");
 		return 1;

-- 
To view, visit https://review.coreboot.org/22345
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I636f6c3d045e297f1439d3e88e43f41e03db4c8e
Gerrit-Change-Number: 22345
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Schander <coreboot at mimoja.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171105/dd11e839/attachment.html>