[coreboot-gerrit] Change in coreboot[master]: nb/intel/x4x: Clarify the raminit memory mapping

Arthur Heymans (Code Review) gerrit at coreboot.org
Sat Nov 4 12:38:41 CET 2017


Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/22328

to look at the new patch set (#3).

Change subject: nb/intel/x4x: Clarify the raminit memory mapping
......................................................................

nb/intel/x4x: Clarify the raminit memory mapping

This replaces magic values by macros and adds some comments to improve
readability.

C1DRB3 Channel 1, rank 3 is now changed (MCHBAR16(0x606) is now 0x0008
instead of 0x0010). Having that rank populated was probably never
tested.

Change-Id: I58923e4a8a756f4ae65f759e7d46e03fad39fab7
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/northbridge/intel/x4x/raminit_ddr2.c
M src/northbridge/intel/x4x/x4x.h
2 files changed, 84 insertions(+), 21 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/22328/3
-- 
To view, visit https://review.coreboot.org/22328
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58923e4a8a756f4ae65f759e7d46e03fad39fab7
Gerrit-Change-Number: 22328
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171104/6cd3d9d8/attachment.html>


More information about the coreboot-gerrit mailing list