[coreboot-gerrit] Change in coreboot[master]: spi/tpm.c do not waste time on wake pulses unless necessary

Vadim Bendebury (Code Review) gerrit at coreboot.org
Fri Nov 3 21:39:58 CET 2017


Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/22321

to look at the new patch set (#2).

Change subject: spi/tpm.c do not waste time on wake pulses unless necessary
......................................................................

spi/tpm.c do not waste time on wake pulses unless necessary

The Cr50 secure chip implementation is guaranteed not to fall asleep
for 1 second after any SPI slave activity.

Let's not waste time on the wake up ping when it is not necessary.

BRANCH=cr50
BUG=b:68012381
TEST=using a protocol analyzer verified that the wake pulses are
     generated only when the new coreboot stage or depthcharge start,
     not on every SPI slave transaction.

Change-Id: Id8def1470ba3eab533075b9e7180f8a58e0b00b6
Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
---
M src/drivers/spi/tpm/tpm.c
1 file changed, 28 insertions(+), 5 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/22321/2
-- 
To view, visit https://review.coreboot.org/22321
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id8def1470ba3eab533075b9e7180f8a58e0b00b6
Gerrit-Change-Number: 22321
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171103/fcd7eaf7/attachment.html>


More information about the coreboot-gerrit mailing list