[coreboot-gerrit] Change in coreboot[master]: mainboard/google/poppy: Power down camera rails when suspending

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/19953 )

Change subject: mainboard/google/poppy: Power down camera rails when suspending
......................................................................


mainboard/google/poppy: Power down camera rails when suspending

BUG=b:62147763

Change-Id: Iba88fed972b847448e01fcfca8c7129d950244c2
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
Reviewed-on: https://review.coreboot.org/19953
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
M src/mainboard/google/poppy/smihandler.c
M src/mainboard/google/poppy/variants/baseboard/include/baseboard/gpio.h
2 files changed, 15 insertions(+), 0 deletions(-)

Approvals:
  Aaron Durbin: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  build bot (Jenkins): Verified



diff --git a/src/mainboard/google/poppy/smihandler.c b/src/mainboard/google/poppy/smihandler.c
index 88aa905..30b009d 100644
--- a/src/mainboard/google/poppy/smihandler.c
+++ b/src/mainboard/google/poppy/smihandler.c
@@ -15,8 +15,11 @@
 
 #include <cpu/x86/smm.h>
 #include <ec/google/chromeec/smm.h>
+#include <gpio.h>
+#include <soc/gpio.h>
 #include <soc/smm.h>
 
+#include <variant/gpio.h>
 #include <variant/ec.h>
 
 void mainboard_smi_espi_handler(void)
@@ -24,10 +27,18 @@
 	chromeec_smi_process_events();
 }
 
+static void mainboard_gpio_smi_sleep(void)
+{
+	/* Hold camera device in reset and then power it down. */
+	gpio_set(EN_CAM_PMIC_RST_L, 0);
+	gpio_set(EN_PP3300_DX_CAM, 0);
+}
+
 void mainboard_smi_sleep(u8 slp_typ)
 {
 	chromeec_smi_sleep(slp_typ, MAINBOARD_EC_S3_WAKE_EVENTS,
 			MAINBOARD_EC_S5_WAKE_EVENTS);
+	mainboard_gpio_smi_sleep();
 }
 
 int mainboard_smi_apmc(u8 apmc)
diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/gpio.h b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/gpio.h
index 628483b..4c9ade3 100644
--- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/gpio.h
+++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/gpio.h
@@ -37,4 +37,8 @@
 /* eSPI virtual wire reporting */
 #define EC_SCI_GPI		GPE0_ESPI
 
+/* Power rail control signals */
+#define EN_PP3300_DX_CAM	GPP_C11
+#define EN_CAM_PMIC_RST_L	GPP_C10
+
 #endif /* BASEBOARD_GPIO_H */

-- 
To view, visit https://review.coreboot.org/19953
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iba88fed972b847448e01fcfca8c7129d950244c2
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>