[coreboot-gerrit] Change in coreboot[master]: mc_bdx1: Switch to RTC RX6110SA

[Werner Zeh (Code Review)]

Werner Zeh has submitted this change and it was merged. ( https://review.coreboot.org/19979 )

Change subject: mc_bdx1: Switch to RTC RX6110SA
......................................................................


mc_bdx1: Switch to RTC RX6110SA

The prior used RTC PCF8523 is replaced with RX6110SA on this mainboard.
Switch to the new RTC in Kconfig and adapt devicetree to the new chip.

Change-Id: I7c4911191cae254900f9a958da42ecd18497484c
Signed-off-by: Werner Zeh <werner.zeh at siemens.com>
Reviewed-on: https://review.coreboot.org/19979
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Mario Scheithauer <mario.scheithauer at siemens.com>
---
M src/mainboard/siemens/mc_bdx1/Kconfig
M src/mainboard/siemens/mc_bdx1/devicetree.cb
2 files changed, 6 insertions(+), 7 deletions(-)

Approvals:
  Mario Scheithauer: Looks good to me, approved
  build bot (Jenkins): Verified



diff --git a/src/mainboard/siemens/mc_bdx1/Kconfig b/src/mainboard/siemens/mc_bdx1/Kconfig
index f64b22b..0200d92 100644
--- a/src/mainboard/siemens/mc_bdx1/Kconfig
+++ b/src/mainboard/siemens/mc_bdx1/Kconfig
@@ -12,7 +12,8 @@
 	select USE_SIEMENS_HWILIB
 	select DRIVER_INTEL_I210
 	select DRIVER_SIEMENS_NC_FPGA
-	select DRIVERS_I2C_PCF8523
+	select DRIVERS_I2C_RX6110SA
+	select RX6110SA_USE_SMBUS
 
 config MAINBOARD_DIR
 	string
diff --git a/src/mainboard/siemens/mc_bdx1/devicetree.cb b/src/mainboard/siemens/mc_bdx1/devicetree.cb
index 804b781..543786b 100644
--- a/src/mainboard/siemens/mc_bdx1/devicetree.cb
+++ b/src/mainboard/siemens/mc_bdx1/devicetree.cb
@@ -11,16 +11,14 @@
 		device pci 1f.2 on end # SATA Controller
 		device pci 1f.3 on
 			# Enable external RTC chip
-			chip drivers/i2c/pcf8523
-				register "cap_sel" = "CAP_SEL_7_PF"
-				register "power_mode" = "PM_BAT_SW_OFF_LOW_DETECT_OFF"
-				register "cof_selection" = "COF_OFF"
+			chip drivers/i2c/rx6110sa
+				register "cof_selection" = "0"
 				register "set_user_date" = "1"
 				register "user_year" = "04"
 				register "user_month" = "07"
 				register "user_day" = "01"
-				register "user_weekday" = "0"
-				device i2c 0x68 on end # RTC PCF8523
+				register "user_weekday" = "4"
+				device i2c 0x32 on end	# RTC RX6110 SA
 			end
 		end # SMBus Controller
 		device pci 1f.5 on end # SATA Controller

-- 
To view, visit https://review.coreboot.org/19979
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7c4911191cae254900f9a958da42ecd18497484c
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>