[coreboot-gerrit] Change in coreboot[master]: mainboard/google/poppy: Power down camera rails when suspending

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19953 )

Change subject: mainboard/google/poppy: Power down camera rails when suspending
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19953/1/src/mainboard/google/poppy/smihandler.c
File src/mainboard/google/poppy/smihandler.c:

Line 33: 	gpio_set(EN_CAM_PMIC_RST_L, 0);
> Should we hold it in reset prior to powering down?
Yes, that makes sense. Updated the sequence and verified as well.


-- 
To view, visit https://review.coreboot.org/19953
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba88fed972b847448e01fcfca8c7129d950244c2
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes