[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: change GPI RXEVCFG default to edge

Kane Chen (Code Review) gerrit at coreboot.org
Wed May 31 06:11:29 CEST 2017


Kane Chen has posted comments on this change. ( https://review.coreboot.org/19992 )

Change subject: soc/intel/skylake: change GPI RXEVCFG default to edge
......................................................................


Patch Set 3:

Should we ask the driver owner to take a look?
>From my observation, the driver seems to enable interrupt first then config the pin to edge trigger during s3 resume.

-- 
To view, visit https://review.coreboot.org/19992
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42b9cd80b494e24c55b97e54cdf59bfd24dd9054
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Kane Chen <kane.chen at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Kane Chen <kane.chen at intel.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: No



More information about the coreboot-gerrit mailing list