[coreboot-gerrit] Change in coreboot[master]: rx6110sa: Add possibility to use both I2C and SMBus for the RTC

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/19978 )

Change subject: rx6110sa: Add possibility to use both I2C and SMBus for the RTC
......................................................................


Patch Set 4:

(3 comments)

https://review.coreboot.org/#/c/19978/4/src/drivers/i2c/rx6110sa/rx6110sa.c
File src/drivers/i2c/rx6110sa/rx6110sa.c:

Line 16: 
> Why the extra line?
It slipped in, will remove it.


PS4, Line 32: CONFIG_RX6110SA_USE_SMBUS
> IS_ENABLED(...)
Oh yes, definitively.


Line 41: 	uint8_t val;
> You probably want to initialize this to 0 as there isn't any error checking
Sure.


-- 
To view, visit https://review.coreboot.org/19978
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4827ae2c544e8002399d94a1159acacd8176c5e9
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes