[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: change GPI RXEVCFG default to edge

Kane Chen (Code Review) gerrit at coreboot.org
Wed May 31 06:06:04 CEST 2017


Hello build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19992

to look at the new patch set (#3).

Change subject: soc/intel/skylake: change GPI RXEVCFG default to edge
......................................................................

soc/intel/skylake: change GPI RXEVCFG default to edge

The original gpio macro sets GPI or native pin RXEVCFG to LEVEL trigger.
This would cause unused interrupts happen while OS is trying to enable
GPIO interrupt and set RXEVCFG to edge trigger for SD_CD pin.
By changing GPI RXEVCFG default to edge can prevent unused interrupts
happen while OS is setting gpio RXEVCFG from level to edge.

BUG=b:62067569
TEST=checked unused interrupt on SD_CD dose not happen after s3 resume

Change-Id: I42b9cd80b494e24c55b97e54cdf59bfd24dd9054
Signed-off-by: Kane Chen <kane.chen at intel.com>
---
M src/soc/intel/skylake/include/soc/gpio.h
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/19992/3
-- 
To view, visit https://review.coreboot.org/19992
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I42b9cd80b494e24c55b97e54cdf59bfd24dd9054
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Kane Chen <kane.chen at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list