[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: Add CPU files

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19723 )

Change subject: soc/amd/stoneyridge: Add CPU files
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/19723/3/src/soc/amd/common/Kconfig
File src/soc/amd/common/Kconfig:

Line 13
> So is there a solution already figured out or we should be doing something 
I don't understand Aaron's comment about someone needing to include the kconfig files.  Of course they need to be added - it's WHERE they're added that is the problem.  So long as they get sourced after the rest of the SOC files, it isn't an issue for overriding default values.  I stick by my initial suggestion as the solution.


-- 
To view, visit https://review.coreboot.org/19723
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b6b1991372c2c6a02709777a73615a86e78ac26
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes