[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Pass GPIO setting in amdinitenv

Marshall Dawson (Code Review) gerrit at coreboot.org
Wed May 31 01:53:38 CEST 2017


Hello build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19839

to look at the new patch set (#4).

Change subject: google/kahlee: Pass GPIO setting in amdinitenv
......................................................................

google/kahlee: Pass GPIO setting in amdinitenv

GPIOs for I2C3 were being unset in amdinitmid if the GPIO
enable table wasn't passed. It had been initialy set in amdinitreset.
Pull the GPIO settings into their own file that can be used in
bootblock and later stages.

Change-Id: I41cd7873f8c8543c95ad8653e0a3887f7d0487a2
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M src/mainboard/google/kahlee/BiosCallOuts.c
M src/mainboard/google/kahlee/Makefile.inc
M src/mainboard/google/kahlee/bootblock/BiosCallOuts.c
A src/mainboard/google/kahlee/gpio.c
4 files changed, 101 insertions(+), 74 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/19839/4
-- 
To view, visit https://review.coreboot.org/19839
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I41cd7873f8c8543c95ad8653e0a3887f7d0487a2
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list