[coreboot-gerrit] Change in coreboot[master]: cpu/amd/car: Fix checkpatch warnings

Philippe Mathieu-Daudé (Code Review) gerrit at coreboot.org
Wed May 31 01:06:24 CEST 2017


Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19988 )

Change subject: cpu/amd/car: Fix checkpatch warnings
......................................................................


Patch Set 1: Code-Review+1

(4 comments)

https://review.coreboot.org/#/c/19988/1/src/cpu/amd/car/disable_cache_as_ram.c
File src/cpu/amd/car/disable_cache_as_ram.c:

PS1, Line 61: msr.lo &= ~(SYSCFG_MSR_MtrrFixDramEn
            : 		| SYSCFG_MSR_MtrrFixDramModEn);
too bad this doesn't fit in one line


https://review.coreboot.org/#/c/19988/1/src/cpu/amd/car/post_cache_as_ram.c
File src/cpu/amd/car/post_cache_as_ram.c:

PS1, Line 51:  
what about those spaces between type cast and value?


PS1, Line 51:  
here too


PS1, Line 67:  
until here


-- 
To view, visit https://review.coreboot.org/19988
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5a5abaa06f8e285ff58436789318cb9cd3b7ac3
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Evelyn Huang <evhuang at google.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list