[coreboot-gerrit] Change in coreboot[master]: purism/librem13v1: Rename librem13 to librem13v1

Youness Alaoui (Code Review) gerrit at coreboot.org
Tue May 30 23:12:48 CEST 2017


Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/19931 )

Change subject: purism/librem13v1: Rename librem13 to librem13v1
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19931/1/src/mainboard/purism/librem13v1/Kconfig
File src/mainboard/purism/librem13v1/Kconfig:

PS1, Line 38: Librem 13 v1
> IIRC, flashrom uses another path and another set of values if it
Humm.. we actually have the VERSION number in smbios already, so maybe it's better to keep it as "Librem 13" for both v1 and v2 hardware, and just have MAINBOARD_VERSION == 1.0 or 2.0 for the v1 vs. v2 (the MAINBOARD_VERSION is already set correctly)


-- 
To view, visit https://review.coreboot.org/19931
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23fa977717230c2001868741bb684e9633a2c0bb
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list