[coreboot-gerrit] Change in coreboot[master]: sb/intel/bd82x6x/early_usb: Use register name

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19954 )

Change subject: sb/intel/bd82x6x/early_usb: Use register name
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/19954/1/src/southbridge/intel/bd82x6x/early_usb.c
File src/southbridge/intel/bd82x6x/early_usb.c:

PS1, Line 74: inw(DEFAULT_PMBASE | UPRWC) & ~UPRWC_WR_EN
> your commit description is "Use register name" but this commit actually doe
Agreed.  It just needs a bit more in the commit message.


-- 
To view, visit https://review.coreboot.org/19954
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f2f3f196c12489613333ab9f6098443edda927f
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes