[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/*/cmos: Remove unused option and checksum fix

Patrick Rudolph (Code Review) gerrit at coreboot.org
Tue May 30 18:37:35 CEST 2017


Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/19955 )

Change subject: mb/lenovo/*/cmos: Remove unused option and checksum fix
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19955/1/src/mainboard/lenovo/l520/cmos.layout
File src/mainboard/lenovo/l520/cmos.layout:

PS1, Line 83: # SandyBridge MRC Scrambler Seed values
            : 896         32        r       0        mrc_scrambler_seed
            : 928         32        r       0        mrc_scrambler_seed_s3
> Given that native raminit is selected in Kconfig (MRC.bin boot path is not 
We could see how much work it is to support MRC and native ram init. If it's not possible to support MRC at all, there should be a bigger code cleanup than just removing those values.


-- 
To view, visit https://review.coreboot.org/19955
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02f7af13d9c82d7f531d4b49b3bc0e5a20c14b55
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list