[coreboot-gerrit] Change in coreboot[master]: [WIP]mainboard/intel/glkrvp: Add GPE routing settings for GL...

[Shaunak Saha (Code Review)]

Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/19739 )

Change subject: [WIP]mainboard/intel/glkrvp: Add GPE routing settings for GLKRVP.
......................................................................


Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/19739/7/src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb
File src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb:

Line 77: 	#PMC_GPE_NW_31_0  - 02
> Are you specifying the bits within each register you are using? I don't und
No. This is actually the numbers in GPE_CFG register representing GPIO community portID mapping. I will remove this comment and merge this pacth with glkrvp mainboard patch.


-- 
To view, visit https://review.coreboot.org/19739
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56a99bbb70ac9edda8448fabf05e3ea90d18d93c
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes