[coreboot-gerrit] Change in coreboot[master]: console/flashsconsole: Add spi flash console for debugging

[Youness Alaoui (Code Review)]

Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/19849 )

Change subject: console/flashsconsole: Add spi flash console for debugging
......................................................................


Patch Set 10:

I've updated the commit so it now generates the CONSOLE FMAP area automatically (and no area if the option is disabled). I also simplified the use of the tx_flush and removed the CBFS support.

I've just tried to test flashconsole on broadwell and it doesn't compile (the lack of monotonic_clock in romstage, and all the global vars in the spi drivers), so I don't know if I should leave it like that, or make the option depend on the FAST_SPI driver (which means skylake+ and no other archs) or if you have a better suggestion, let me know.

-- 
To view, visit https://review.coreboot.org/19849
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74a297b94f6881d8c27cbe5168f161d8331c3df3
Gerrit-PatchSet: 10
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: No