[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy:[WIP] Add MIPI camera support.

[Rajmohan Mani (Code Review)]

Rajmohan Mani has posted comments on this change. ( https://review.coreboot.org/19621 )

Change subject: mb/google/poppy:[WIP] Add MIPI camera support.
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19621/1/src/mainboard/google/poppy/acpi/camera.asl
File src/mainboard/google/poppy/acpi/camera.asl:

PS1, Line 129: Sleep(3)
> @Raj, having delays/sleep in ASL code, is that a good idea? Besides, how is
Since this is related to power sequencing of the sensors and vcm (that involve powering up/down voltage rails), which inherently require delays in stabilizing its output, this is needed.
These values are arrived based on the specs and the optimal values found during validation.


-- 
To view, visit https://review.coreboot.org/19621
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If32a2a8313488d2f50aad3feaa79e17b1d06c80f
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang at intel.com>
Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes