[coreboot-gerrit] Change in coreboot[master]: google/chell: add board-specific USB port info

[Matt DeVillier (Code Review)]

Matt DeVillier has uploaded a new change for review. ( https://review.coreboot.org/19976 )

Change subject: google/chell: add board-specific USB port info
......................................................................

google/chell: add board-specific USB port info

Add capability and location data for USB ports/devices via
_PLD and _UPC ACPI methods, which is utilized by Windows and
required by macOS.

Change-Id: Ie0b64eadc634049f6b65cf555407337fb7c4363c
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/mainboard/google/chell/acpi/mainboard.asl
A src/mainboard/google/chell/acpi/usb.asl
2 files changed, 162 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/19976/1

diff --git a/src/mainboard/google/chell/acpi/mainboard.asl b/src/mainboard/google/chell/acpi/mainboard.asl
index 4d0f3fd..5d382c4 100644
--- a/src/mainboard/google/chell/acpi/mainboard.asl
+++ b/src/mainboard/google/chell/acpi/mainboard.asl
@@ -22,3 +22,6 @@
 		Name (_HID, EisaId ("PNP0C0C"))
 	}
 }
+
+/* USB port entries */
+#include "usb.asl"
diff --git a/src/mainboard/google/chell/acpi/usb.asl b/src/mainboard/google/chell/acpi/usb.asl
new file mode 100644
index 0000000..aa465fa
--- /dev/null
+++ b/src/mainboard/google/chell/acpi/usb.asl
@@ -0,0 +1,159 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+Scope (\_SB.PCI0.XHCI.RHUB.HS01)
+{
+	// Left Rear USB 2.0 Type-C
+	Name (_UPC, Package (0x04)
+	{
+		0xFF,	// Connectable
+		Zero,	// USB Port
+		Zero,	// Reserved
+		Zero	// Reserved
+	})
+
+	// Visible
+	Method (_PLD, 0, NotSerialized)
+	{
+		Return (GPLD (One))
+	}
+}
+Scope (\_SB.PCI0.XHCI.RHUB.HS02)
+{
+	// Left Rear USB 2.0 Type-C
+	Name (_UPC, Package (0x04)
+	{
+		0xFF,	// Connectable
+		Zero,	// USB Port
+		Zero,	// Reserved
+		Zero	// Reserved
+	})
+
+	// Visible
+	Method (_PLD, 0, NotSerialized)
+	{
+		Return (GPLD (One))
+	}
+}
+Scope (\_SB.PCI0.XHCI.RHUB.HS03)
+{
+	// Bluetooth
+	Name (_UPC, Package (0x04)
+	{
+		0xFF,	// Connectable
+		0xFF,	// OEM Connector
+		Zero,	// Reserved
+		Zero	// Reserved
+	})
+
+	// Not Visible
+	Method (_PLD, 0, NotSerialized)
+	{
+		Return (GPLD (Zero))
+	}
+}
+Scope (\_SB.PCI0.XHCI.RHUB.HS04)
+{
+	// SD Card
+	Name (_UPC, Package (0x04)
+	{
+		0xFF,	// Connectable
+		0xFF,	// OEM Connector
+		Zero,	// Reserved
+		Zero	// Reserved
+	})
+
+	// Not Visible
+	Method (_PLD, 0, NotSerialized)
+	{
+		Return (GPLD (Zero))
+	}
+}
+Scope (\_SB.PCI0.XHCI.RHUB.HS05)
+{
+	// Left USB 2.0 Type-A
+	Name (_UPC, Package (0x04)
+	{
+		0xFF,	// Connectable
+		Zero,	// USB Port
+		Zero,	// Reserved
+		Zero	// Reserved
+	})
+
+	// Visible
+	Method (_PLD, 0, NotSerialized)
+	{
+		Return (GPLD (One))
+	}
+}
+Scope (\_SB.PCI0.XHCI.RHUB.HS07)
+{
+	// Webcam
+	Name (_UPC, Package (0x04)
+	{
+		0xFF,	// Connectable
+		0xFF,	// OEM Connector
+		Zero,	// Reserved
+		Zero	// Reserved
+	})
+
+	// Not Visible
+	Method (_PLD, 0, NotSerialized)
+	{
+		Return (GPLD (Zero))
+	}
+}
+Scope (\_SB.PCI0.XHCI.RHUB.SS01)
+{
+	// Left Rear USB 3.0 Type-C
+	Name (_UPC, Package (0x04)
+	{
+		0xFF,	// Connectable
+		0x03,	// USB 3.0 Port
+		Zero,	// Reserved
+		Zero	// Reserved
+	})
+}
+Scope (\_SB.PCI0.XHCI.RHUB.SS02)
+{
+	// Left Front USB 3.0 Type-C
+	Name (_UPC, Package (0x04)
+	{
+		0xFF,	// Connectable
+		0x03,	// USB 3.0 Port
+		Zero,	// Reserved
+		Zero	// Reserved
+	})
+}
+Scope (\_SB.PCI0.XHCI.RHUB.SS03)
+{
+	// Left USB 3.0 Type-A
+	Name (_UPC, Package (0x04)
+	{
+		0xFF,	// Connectable
+		0x03,	// USB 3.0 Port
+		Zero,	// Reserved
+		Zero	// Reserved
+	})
+}
+Scope (\_SB.PCI0.XHCI.RHUB.SS04)
+{
+	// SD Card
+	Name (_UPC, Package (0x04)
+	{
+		0xFF,	// Connectable
+		0x03,	// USB 3.0
+		Zero,	// Reserved
+		Zero	// Reserved
+	})
+}

-- 
To view, visit https://review.coreboot.org/19976
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0b64eadc634049f6b65cf555407337fb7c4363c
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>