[coreboot-gerrit] Change in coreboot[master]: Kconfig: Move CONFIG_VIDEO_MB

Martin Roth (Code Review) gerrit at coreboot.org
Sat May 27 17:02:14 CEST 2017


Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/19748 )

Change subject: Kconfig: Move CONFIG_VIDEO_MB
......................................................................


Kconfig: Move CONFIG_VIDEO_MB

Via/VX800 was the last chip not defining it.

Change-Id: Idd03f48bed881a5846b1bb3bf29254450d6cff3b
Signed-off-by: Nico Huber <nico.h at gmx.de>
Reviewed-on: https://review.coreboot.org/19748
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
M src/Kconfig
M src/northbridge/via/vx800/Kconfig
2 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Aaron Durbin: Looks good to me, approved
  build bot (Jenkins): Verified



diff --git a/src/Kconfig b/src/Kconfig
index 8b2369a..4091a61 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -541,11 +541,6 @@
 	hex
 	default 0x0
 
-# TODO: Can probably be removed once all chipsets have kconfig options for it.
-config VIDEO_MB
-	int
-	default 0
-
 config USE_WATCHDOG_ON_BOOT
 	bool
 	default n
diff --git a/src/northbridge/via/vx800/Kconfig b/src/northbridge/via/vx800/Kconfig
index 9bcb7cd..a165253 100644
--- a/src/northbridge/via/vx800/Kconfig
+++ b/src/northbridge/via/vx800/Kconfig
@@ -4,3 +4,8 @@
 	select HAVE_DEBUG_RAM_SETUP
 	select HAVE_DEBUG_SMBUS
 	select LATE_CBMEM_INIT
+
+config VIDEO_MB
+	int
+	default 0 # FIXME
+	depends on NORTHBRIDGE_VIA_VX800

-- 
To view, visit https://review.coreboot.org/19748
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idd03f48bed881a5846b1bb3bf29254450d6cff3b
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list