[coreboot-gerrit] Change in coreboot[master]: console/flashsconsole: Add spi flash console for debugging

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19849 )

Change subject: console/flashsconsole: Add spi flash console for debugging
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/19849/2/src/console/Kconfig
File src/console/Kconfig:

Line 258: 	  region in the CBFS.
> This was discussed on IRC with Aaron. Adding it to the default FMAP would m
Can't you just put something like ##CONSOLE_ENTRY## and replace it either with the full line or with nothing? I'm pretty sure the fmd parser just ignores empty lines...


https://review.coreboot.org/#/c/19849/9/src/drivers/spi/flashconsole.c
File src/drivers/spi/flashconsole.c:

Line 93: 			car_set_var(g_rdev, rdev);
> The FMAP and CBFS APIs already do prints, such as :
Hmm... right. That's unfortunate. Okay.


-- 
To view, visit https://review.coreboot.org/19849
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74a297b94f6881d8c27cbe5168f161d8331c3df3
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes