[coreboot-gerrit] Change in coreboot[master]: google/gru: enable the pull high for touchpad

[Caesar Wang (Code Review)]

Caesar Wang has posted comments on this change. ( https://review.coreboot.org/19863 )

Change subject: google/gru: enable the pull high for touchpad
......................................................................


Patch Set 2:

> Sorry, I don't quite understand what problem is solved here. Do you
 > have a link to a Google bug with more information? (It's okay to
 > put BUG=b:XXXX lines in these patches, even if they're
 > access-restricted.)

https://partnerissuetracker.corp.google.com/u/2/issues/36705749


 > 
 > The touchpad is not accessed by the firmware and the kernel should
 > reset it when it's initializing. Why does this GPIO have to be
 > configured in firmware? What's the harm in doing it later?

-- 
To view, visit https://review.coreboot.org/19863
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a67d1c041afafde24ed9f00716ba41a9b41a8da
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Caesar Wang <wxt at rock-chips.com>
Gerrit-Reviewer: Caesar Wang <wxt at rock-chips.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philip Chen <philipchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: No